Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoring system (styled) #4

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

mildrrnt
Copy link
Contributor

@mildrrnt mildrrnt commented Jan 5, 2024

Change made

  • Bug fixes
  • New features
  • Breaking changes

Describe what you have done

  • Using Nano Store to store score for each type of cocktail in Local Storage as a dictionary.
  • Implement function addScores for incrementing scores in Local Storage.

To use this function, put all the scores in the array, ref: https://docs.google.com/spreadsheets/d/1mNXxFkeMe6F8OLMtUAHQC6k08szvkr-1pVxFDGD-srU/

  • Implement logic for displaying and resetting scores for debugging.
  • Add props scoreArray to Button component to store changes in scores for all types.
  • Add props redirect to Button component to implement logic of going to the next page.

New Features

  • Update scores

Fix

  • Run Prettier.

@mildrrnt mildrrnt requested a review from shalluv January 5, 2024 19:58
@mildrrnt mildrrnt self-assigned this Jan 5, 2024
shalluv
shalluv previously approved these changes Jan 10, 2024
Copy link
Member

@shalluv shalluv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!

@shalluv shalluv merged commit 50c269e into dev Jan 10, 2024
1 check passed
@shalluv shalluv deleted the worranittha/gea-35-able-to-update-scores branch January 10, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants