Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

add rough reconnection support #541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucyllewy
Copy link

  • this breaks currently when your nickname is already in use and I'm unsure why.

reference: issue #235

- this breaks currently when your nickname is already in use and I'm unsure why.
@Xe
Copy link
Contributor

Xe commented Nov 20, 2015

Does slate-irc not hook on nickname in use before receiving 001?

@lucyllewy
Copy link
Author

don't merge this yet - there's a problem: the reconnection spawns exponential numbers of attempts simultaneously at each failed attempt.

@jgillich
Copy link

@diddledan What's the status of this?

@astorije
Copy link
Collaborator

@diddledan, did you make any progress on this?
I know @xPaw and @erming mentioned constant reconnection errors, maybe they can give their input here too?

stream.end();
var msg = new Msg({
type: Msg.Type.ERROR,
text: "Connection error. Reconnecting in 30 seconds."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeframe in this message doesn't match the setTimeout below -- maybe extract a variable?

@edbrannin
Copy link

@diddledan Any idea why it spawns exponential reconnection attempts? Does the error-handler fire multiple times per disconnect or something?

@bews
Copy link

bews commented May 5, 2016

@edbrannin @diddledan I fixed exponential reconnection attempts and added reconnection on ping timeout - will upload working version soon.

P.S. "nickname is already in use" problem doesn't occur, already fixed?

@astorije
Copy link
Collaborator

astorije commented May 5, 2016

@bews, just to let you know, development on Shout has become inactive, so it's likely that you will not get an answer to your question(s).

FYI, the officially supported fork The Lounge has active development around automatic reconnection support, see thelounge/thelounge#254.
The reason why the fork's PR is much smaller than any attempt that could be made on Shout is because we recently switched to a different underlying library for IRC, and it aims to handle reconnection itself.

It's not quite there yet, but almost. I wanted to chime in to avoid duplicating similar work :-)

@bews
Copy link

bews commented May 5, 2016

@astorije well, when I started working with Shout I didn't know about Lounge fork, so I'll stick with this one :)

I've modified a lot of things here, some of them will be uploaded soon.

@astorije
Copy link
Collaborator

astorije commented May 5, 2016

Ok then! :-) Just know that the maintainers' team has moved to The Lounge so if you want to contribute, it's more likely that your work will be merged there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants