Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild application in React #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rebuild application in React #10

wants to merge 2 commits into from

Conversation

erksch
Copy link
Owner

@erksch erksch commented Apr 26, 2020

As I wanted to add more features to the viewer, I found using the standard way of doing things with javascript DOM manipulation tedious as ever. Since I use React on a daily bases in various projects I decided to reimplement everything with React and the awesome library react-threejs-fiber for the rendering code. This also allowed me to give the app a facelift for stuff like loading segments and error handling, since state is much easier to handle.

With the react rebuild come to new features: support for 3D object detection and semantic segmentation. You can specify a server where the current frame is sent to, the server should respond with bounding boxes for 3D object detection) or point labels for segmentation. The viewer then automatically displays the result!

This pull request is still very work in progress, it currently lacks:

  • Updated README how build and use the react app
  • Template code for servers that run segmentation or object detection and communicate with the viewer
  • Polish for loading indications and error messages
  • Polish for styling components and remove all inline styling

@erksch erksch mentioned this pull request Apr 26, 2020
@Nuri-benbarka
Copy link
Contributor

@erksch
now only the first frame in the segment is loading.

@erksch
Copy link
Owner Author

erksch commented Apr 28, 2020

@Nuri-benbarka As I can't make a commit right now, you can fix the problem by removing the two comments in useWebsocket.ts. The lines commented out are responsible for continuous fetching.
Line 83 and 128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants