Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vfp] Fix issue related to df2res #478

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Jan 24, 2024

Fix issues related to vfp df2res

  • Ensure space between values
  • Preserve white-space in output comment
  • Fix bug with only dumping last table
  • Ensure similar format for VFPPROD and VFPINJ

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fdf25e4) 95.17% compared to head (52edea7) 95.18%.

❗ Current head 52edea7 differs from pull request most recent head 544dfb1. Consider uploading reports for the commit 544dfb1 to get more accurate results

Files Patch % Lines
res2df/vfp/_vfp.py 0.00% 1 Missing ⚠️
res2df/vfp/_vfpinj.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   95.17%   95.18%           
=======================================
  Files          33       33           
  Lines        4460     4463    +3     
=======================================
+ Hits         4245     4248    +3     
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alifbe alifbe merged commit d12ea99 into equinor:master Jan 25, 2024
7 checks passed
@alifbe alifbe deleted the df2res-formatting branch January 25, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants