Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy jupyter config and data dirs into komodoenv for notebook>=7 #71

Merged
merged 2 commits into from
May 14, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented May 13, 2024

Issue
Resolves #69

Approach
Copies the config and data dir from the komodo release into the komodoenv.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

Copy link

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! ✈️

@larsevj larsevj force-pushed the try_fix_jupyter_for_komodoenv branch from 3e98c3f to 0a99ed3 Compare May 14, 2024 09:54
@larsevj larsevj merged commit 7f9ac68 into main May 14, 2024
6 checks passed
@larsevj larsevj deleted the try_fix_jupyter_for_komodoenv branch May 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jupyter notebook started inside a komodoenv breaks
2 participants