Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for fit_seromodel() #213

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add unit test for fit_seromodel() #213

merged 3 commits into from
Oct 2, 2024

Conversation

ntorresd
Copy link
Member

This PR adds unit test for new version of fit_seromodel (v.1.0.1), partially addressing #210.

@ntorresd ntorresd mentioned this pull request Sep 16, 2024
Open
@ntorresd ntorresd marked this pull request as ready for review September 16, 2024 22:31
ben18785
ben18785 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@ben18785 ben18785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ntorresd -- I think as discussed we can handle more tests of the models via testing of the actual Stan functions but that will be handled in a separate PR.

@ntorresd ntorresd merged commit 373ca61 into dev Oct 2, 2024
1 of 6 checks passed
@ntorresd ntorresd deleted the dev-test-fit_seromodel branch October 2, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben18785 ben18785 ben18785 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntorresd @ben18785