vectorise prob_discrete_erlang #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
TimTaylor
commented
Feb 8, 2024
R/model_ebola.R
Outdated
| @@ -27,7 +27,7 @@ prob_discrete_erlang <- function(shape, rate) { | |||
| one_sub_cumulative_probs[n_bin] <- sum(total) | |||
| cumulative_prob <- 1 - one_sub_cumulative_probs[n_bin] | |||
| } | |||
| one_sub_cumulative_probs <- c(1, one_sub_cumulative_probs[1:n_bin]) | |||
| one_sub_cumulative_probs <- c(1, one_sub_cumulative_probs[seq(n_bin)]) | |||
There was a problem hiding this comment.
cough seq_len cough 😉
Use seq_len() for sequence
pratikunterwegs
force-pushed
the
erlang-tweaks
branch
from
3a8b492
to
a337626
Compare
|
Leaving the comment re: sufficient length in as a reminder to revisit the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how much this improves performance but there were some opportunities to vectorise this (at expense of more memory usage). Have also preallocated one of the outputs - not sure if that will help or not.