Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #102: Rename model functions to model_x() #135

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

bahadzie
Copy link
Member

No description provided.

@pratikunterwegs
Copy link
Collaborator

Thanks @bahadzie - will take a look later today.

Copy link
Collaborator

@pratikunterwegs pratikunterwegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bahadzie for this - since it's a change that affects nearly every file in the codebase, I will merge this after #132 and #126 as that seems like the way to minimise merge conflicts - although there will be a lot of those anyway.

Further branches/PRs should probably wait until this set of PRs is merged, to avoid more merge conflicts still.

inst/WORDLIST Show resolved Hide resolved
@pratikunterwegs
Copy link
Collaborator

Waiting on epiverse-trace/.github#18 to be merged so that RcppExports is excluded from linting.

@pratikunterwegs pratikunterwegs merged commit 55be2f4 into main Nov 6, 2023
11 checks passed
@pratikunterwegs pratikunterwegs deleted the bahadzie/issue102 branch November 6, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants