Misc suggestions for simulate_chains() #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit is breaking the tests but I'm not completely sure why: |
sbfnk
reviewed
Jan 30, 2024
4 tasks
Since tf is Inf by default
Since n_offspring[!sim] is set to 0
This reverts commit 45e29bf.
Co-authored-by: Sebastian Funk <[email protected]>
jamesmbaazam
force-pushed
the
cyclocomp
branch
from
6bb0880
to
13ecc86
Compare
jamesmbaazam
approved these changes
Jan 30, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggestions here come from investigating #179.
Indeed, the code here gives a cyclomatic complexity of 18. Some changes might be subjective preferences so feel free to cherry pick the changes you like.