Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more options to fine tune positioning, omit/change prefix, modify QR code look and visual splitting of the printed number #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Unostot
Copy link

@Unostot Unostot commented Jun 4, 2024

This is one of my first tries to contribute something, so it might not be the perfect pull request...help appreciated :)

I Added new options to customize and fine tune the printed labels:

  • --prefix: Prefix in front of digits (default: ASN)
  • --omit-prefix: Do not print prefix in front of digits (just use it in the generated QR code)
  • --x-offset: Horizontal (X) offset in mm (default: 0)
  • --y-offset: Vertical (Y) offset in mm (default: 0)
  • --qr-scale-factor: Scale Factor of QR code (default: 0.9). Makes this option easier to play around until satisfied with the look.
  • --qr-border-size: Size of white border around QR code (default: 4) Makes this option easier to play around until satisfied with the look.
  • --split-at: visually split printed number at given digit position . Multiple timse allowed to add multiple spaces.

x/y offsets of whole label array, omit printing of the label, qr scale factor, qr border size and visual splitting of the printed number
@margau margau mentioned this pull request Jul 13, 2024
@vicegold
Copy link

Is this blocked by anything? Would love to use a different prefix :)

Copy link

@alexanderbittner alexanderbittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the code and running this locally to try out the new arguments, this appears to work well. No idea why the CI doesn't work on this PR, as posted above.
Let's hope a manual review helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants