feat: add herma 4346 labels #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margau
approved these changes
Jan 6, 2024
|
The issues I had were 97% scaling on iOS - this works perfect |
|
This looks good to me. We might also wanna add this to the README? |
|
Just lgtm |
margau
requested changes
Apr 17, 2024
There was a problem hiding this comment.
If this is tested and working, can we add this to the "known good" labels in https://github.com/entropia/paperless-asn-qr-codes#supported-sheets ?
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the herma 4346 labels. They print okay - everything is on the label. The first row prints at the bottom of the label, the last row at the very top. But I think it's a general issue - as the measurements are very precise.
Thank you for your great work