macOS: Add fallback to ASCII-capable keyboard layout for handling non-standard input sources #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-standard input sources Added an additional fallback in create_string_for_key() to handle cases where TISGetInputSourceProperty returns NULL after switching to the default keyboard layout via TISCopyCurrentKeyboardLayoutInputSource(). This fallback calls TISCopyCurrentASCIICapableKeyboardLayoutInputSource() to ensure that an ASCII-capable layout is used when the system's current layout does not provide valid Unicode key layout data. This increases robustness when dealing with non-standard or custom keyboard layouts, preventing potential failures during input simulation.
pentamassiv
force-pushed
the
currentKeyboardLayoutASCII
branch
from
c6f7d3b
to
55f4404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional fallback in
create_string_for_key()to handle cases whereTISGetInputSourcePropertyreturnsNULLafter switching to the default keyboard layout viaTISCopyCurrentKeyboardLayoutInputSource().This fallback calls
TISCopyCurrentASCIICapableKeyboardLayoutInputSource()to ensure that an ASCII-capable layout is used when the system's current layout does not provide valid Unicode key layout data. This increases robustness when dealing with non-standard or custom keyboard layouts, preventing potential failures during input simulation.