Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial pass at enabling dom diffing for custom element templates con… #7

Merged
merged 10 commits into from
May 30, 2024
Merged

Initial pass at enabling dom diffing for custom element templates con… #7

merged 10 commits into from
May 30, 2024

Conversation

kristoferjoseph
Copy link
Contributor

…taining slots

@macdonst
Copy link
Contributor

@kristoferjoseph seems good to me but do we have any test cases we can add?

@kristoferjoseph
Copy link
Contributor Author

@kristoferjoseph seems good to me but do we have any test cases we can add?

This is what I have been working on. There are a ton of edge cases and it requires the tests to pull in all of the other mixins to test correctly.

@kristoferjoseph
Copy link
Contributor Author

This is still very much a WIP as I keep uncovering more and more edge cases.

kristoferjoseph
kristoferjoseph commented May 23, 2024
View reviewed changes
index.mjs Outdated Show resolved Hide resolved
kristoferjoseph
kristoferjoseph commented May 23, 2024
View reviewed changes
test/diff-test.html Outdated Show resolved Hide resolved
@kristoferjoseph
Update ci.yml
021c711 
Moved to `npm i` from `npm ci` so that builds will run without the need for `package-lock.json` files
ryanbethel
ryanbethel approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ryanbethel ryanbethel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we add the small fix I made in the other PR for scope=global style tags.

@kristoferjoseph
Copy link
Contributor Author

LGTM. Should we add the small fix I made in the other PR for scope=global style tags.

Seems like a good idea so that these changes all go out in one release

@macdonst macdonst mentioned this pull request May 23, 2024
Closed
@kristoferjoseph kristoferjoseph merged commit 3cf0d40 into main May 30, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
@kristoferjoseph kristoferjoseph deleted the dom-diffing-slots branch May 31, 2024 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macdonst macdonst macdonst approved these changes

@ryanbethel ryanbethel ryanbethel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristoferjoseph @macdonst @ryanbethel