properly remove script tags

enhance-dev · Jun 6, 2024 · b7b5afb · b7b5afb
1 parent bae4d38
commit b7b5afb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/index.mjs b/index.mjs
@@ -35,7 +35,7 @@ const CustomElementMixin = (superclass) => class extends superclass {
     // Removes script tags as they are already appended to the body by SSR
     // TODO: If only added dynamically in the browser we need to insert the script tag after running the script transform on it. As well as handle deduplication.
     el.querySelectorAll('script')
-      .forEach((tag) => { el.content.removeChild(tag) })
+      .forEach((tag) => { el.removeChild(tag) })
   }
 
   removeStyleTags(el) {

diff --git a/test/diff-test.html b/test/diff-test.html
@@ -85,6 +85,9 @@ <h1>${heading}</h1>
         <p>${heading}</p>
         <a href="/foo/${heading}"></a>
         <slot></slot>
+        <script>
+          console.log("Script should be removed")
+        <${'/script>'}
       `
     }