Use copy instead of rename if temp directory is on a different device

[bryanwood]

Running npx "@enhance/create@latest" ./myproject -y on Windows when the temp directory isn't on the same disk/device as the project directory fails with Error: EXDEV: cross-device link not permitted.

Using copySync instead of renameSync fixes the scenario but I'm not sure if the change in this PR is a good idea or not.

[macdonst]

Hey @bryanwood thanks for the PR. I'm glad you caught this bug. I'm away from my Windows box right now so I can't fully test this but I have left some comments on the PR that I think will get this in a state in which we can merge.

[bryanwood]

Have addressed the comments and learnt today that node has had APIs for doing recursive directory copying for a while now 😅.

There's another PR #18 that makes the tests run on Windows.

[macdonst]

@bryanwood this is great, thanks for making those changes. I merged #18 into main. Can you pull those changes into this branch? That way all the tests will run clean on GitHub.

[bryanwood]

Looks like cpSync is only in node >= 16.7

https://nodejs.org/api/fs.html#fscpsyncsrc-dest-options

[macdonst]

@bryanwood I've pushed a new branch https://github.com/enhance-dev/create/tree/use-copy-when-different-filesystem-roots which has all your commits plus my own implementation of cpSync. Can you pull down the branch and test it on your machine? Seems to be working on mine and in GH Actions but I'd love for the original reporter to validate the fix. Once that's done will commit and cut a new release.

[bryanwood]

Have tested this locally and it works ^^.

[macdonst]

@bryanwood thanks for the confirmation. I've pushed the code from my branch with the node 14 copy sync implementation and released an @enhance/create v3.1.3 to include the fix.