Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embind] Better reflect the actual class hierarchy in TS. #22734

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[embind] Better reflect the actual class hierarchy in TS. #22734

wants to merge 1 commit into from

Conversation

brendandahl
Copy link
Collaborator

  • All classes now extend from ClassHandle, which is what really happens in JS.
  • Add the missing methods that are available on ClassHandles.

Fixes #22701

@brendandahl
[embind] Better reflect the actual class hierarchy in TS.
1693f99 
 - All classes now extend from ClassHandle, which is what really
   happens in JS.
 - Add the missing methods that are available on ClassHandles.
sbc100
sbc100 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deleteLater() and setDelayFunction(...) to TypeScript definitions and make them official API
2 participants
@brendandahl @sbc100