[tsgen] Expand TS generation test to compile and run a TS file. #22582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the new TS file we can add tests for things where just checking if the definition file compiles is not enough. This will help catch issues like emscripten-core#22569.
brendandahl
commented
Sep 18, 2024
| Bar bar; | ||
| std::string string; |
There was a problem hiding this comment.
I changed this to be a more realistic use of a ValueObject.
sbc100
reviewed
Sep 18, 2024
test/test_other.py
Outdated
|
|
||
| # Test that the output compiles with a TS file that uses the defintions. | ||
| cmd = shared.get_npm_cmd('tsc') + ['embind_tsgen.d.ts', '--noEmit'] | ||
| shutil.copyfile(test_file('other/embind_tsgen.ts'), 'main.ts') | ||
| # A package file with type=module is needed to allow top level await in TS. |
There was a problem hiding this comment.
Can you instead use the .mjs extension?
| shutil.copyfile(test_file('other/embind_tsgen.ts'), 'main.ts') | ||
| # A package file with type=module is needed to allow top level await in TS. | ||
| shutil.copyfile(test_file('other/embind_tsgen_package.json'), 'package.json') | ||
| cmd = shared.get_npm_cmd('tsc') + ['embind_tsgen.d.ts', 'main.ts', '--module', 'NodeNext', '--moduleResolution', 'nodenext'] |
There was a problem hiding this comment.
Why doesn't tsc generate a file called .mjs here I wonder?
Is the package.json file here needed for running tsc or for running the output?
- Use different expected test file now that the output is different. -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new TS file we can add tests for things where just checking if the definition file compiles is not enough. This will help catch issues like #22569.