Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop for Painter in egui_glow #5285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop for Painter in egui_glow #5285

wants to merge 1 commit into from

Conversation

rustbasic
Copy link
Contributor

Drop for Painter in egui_glow

@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5285-patch140
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

emilk
emilk reviewed Oct 23, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm 🤔

At this point we could just destroy in the destructor, with no need for an explicit .destroy() function

@rustbasic
Copy link
Contributor Author

rustbasic commented Oct 23, 2024 •
edited
Loading

When an error occurs in the program, warn!() is printed . This does not fit the situation.

If not sure whether destroy() will happen, it might be better to just call destroy() instead of handling it with warn!().

If you don't need it, please close it.

@rustbasic rustbasic requested a review from emilk October 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustbasic @emilk