Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Submenus are inaccessible via keyboard Enter/Space (Response::fake_primary_click) #5230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix : Submenus are inaccessible via keyboard Enter/Space (Response::fake_primary_click) #5230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6995f5
fixed submenu keyboard click
abdul2801 Oct 7, 2024
826be22
formatted
abdul2801 Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/egui/src/menu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,9 @@ impl MenuState {
// We don't close the submenu if the pointer is on its way to hover it.
// ensure to repaint once even when pointer is not moving
ui.ctx().request_repaint();
} else if !open && button.hovered() {
} else if !open
&& (button.hovered() || self.hovering_current_submenu(&pointer) || button.clicked())
{
// TODO(emilk): open menu to the left if there isn't enough space to the right
let mut pos = button.rect.right_top();
pos.x = self.rect.right() + ui.spacing().menu_spacing;
Expand Down