Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable manual_range_contains lint #5214

Closed
wants to merge 1 commit into from
Closed

enable manual_range_contains lint #5214

wants to merge 1 commit into from

Conversation

bircni
Copy link
Contributor

@bircni bircni commented Oct 2, 2024

Enabled the manual_range_contains lint

  • I have followed the instructions in the PR template

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Preview available at https://egui-pr-preview.github.io/pr/5214-patch16
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@rustbasic
Copy link
Contributor

rustbasic commented Oct 3, 2024 •
edited
Loading

I don't like the restriction of the manual_range_contains lint.
just my opinion.

@bircni
Copy link
Contributor Author

bircni commented Oct 3, 2024

I think this makes the code more readable I Like it

@rustbasic
Copy link
Contributor

I think this makes the code more readable I Like it

Yes, it improves readability, but I think it would be better to allow it.
Freedom is being reduced more and more.
just my opinion.

@emilk
Copy link
Owner

emilk commented Oct 3, 2024

No, I don't like it

@emilk emilk closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bircni @rustbasic @emilk