-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Support putting UI next to the dynamic island #5211
Conversation
winit::Window::inner_size returns size of safe area on iOS. use winit::Window::outer_size on iOS
Preview available at https://egui-pr-preview.github.io/pr/5211-iOS-black-bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. Now we will still have to manually work around the safe area (until this is done: rust-windowing/winit#3890) but at least egui will render on the whole screen
@lucasmerlin I updated my safe area implementation so it is actually usable. it could be merged and the get_safe_area_insets could be replaced while upgrading winit in the future |
@emilk is this alright? |
Co-authored-by: Emil Ernerfeldt <[email protected]>
winit::Window::inner_size returns size of safe area on iOS. use winit::Window::outer_size on iOS
The dimensions of outer_size include the title bar and borders, but as far as I know there is no way to actually display the title bar or borders on iOS so it should be fine.