Build with the "org.embulk.embulk-plugins" Gradle plugin #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civitaspo
reviewed
Feb 7, 2020
There was a problem hiding this comment.
@dmikurube thanks for this change and I'm sorry for the late response. It looks almost good for me and I fix the CI later. But there is one thing I want to clarify. What is the best way to make examples worked? (https://github.com/civitaspo/embulk-filter-expand_json#run-example)
|
Once you run We may have another separate task just to create this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As we talked in the Developers' Meeting, we're going to use the new Gradle plugin to build Embulk plugins.
https://plugins.gradle.org/plugin/org.embulk.embulk-plugins
https://github.com/embulk/gradle-embulk-plugins
I'm trying to apply it with some upgrades. Can you have a look?