Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix unsoundness due to impl Trait, improve macro error handling. #3425

Merged
merged 4 commits into from
Oct 18, 2024
Merged

executor: fix unsoundness due to impl Trait, improve macro error handling. #3425

merged 4 commits into from
Oct 18, 2024

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Oct 18, 2024

  • executor-macros: don't parse function bodies.
  • executor-macros: refactor for better recovery and ide-friendliness on errors.
  • executor-macros: disallow impl Trait in task arguments.

@Dirbaio Dirbaio merged commit 1f58e0e into main Oct 18, 2024
5 of 6 checks passed
@Dirbaio Dirbaio deleted the macro-fixes branch October 18, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dirbaio