Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32/i2c: disable pullup instead of pulling down #3410

Merged
merged 1 commit into from
Oct 10, 2024
Merged

stm32/i2c: disable pullup instead of pulling down #3410

merged 1 commit into from
Oct 10, 2024

Conversation

Sh3Rm4n
Copy link
Contributor

@Sh3Rm4n Sh3Rm4n commented Oct 10, 2024 •
edited
Loading

In #3006 it was changed, that i2c gpios are set to Pull::Down instead of the previous Pull::None, when Config::scl_pullup is set to false (which is the default).

I don't think this was an intended change and I can't think of a scenario, where a Pull::Down is needed for the I2C bus.

This merge request changes it to be Pull::None again.

@Sh3Rm4n Sh3Rm4n changed the title stm32/i2c: disable pullup instead of pulldown stm32/i2c: disable pullup instead of pulling down Oct 10, 2024
Dirbaio
Dirbaio approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops very true, pulldown on i2c makes no sense indeed. thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Oct 10, 2024
Merged via the queue into embassy-rs:main with commit e7dfc2b Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sh3Rm4n @Dirbaio