-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RP2350 TRNG support #3338
Merged
Merged
RP2350 TRNG support #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionspin
force-pushed
the
add-rp2350-trng-support
branch
6 times, most recently
from
September 15, 2024 20:08
faeab00
to
9de7fa1
Compare
ionspin
commented
Sep 15, 2024
Dirbaio
reviewed
Sep 15, 2024
ionspin
force-pushed
the
add-rp2350-trng-support
branch
2 times, most recently
from
September 16, 2024 19:42
1f3f775
to
9422c21
Compare
ionspin
force-pushed
the
add-rp2350-trng-support
branch
from
September 16, 2024 20:03
9422c21
to
5f09e3b
Compare
Dirbaio
reviewed
Sep 16, 2024
Dirbaio
reviewed
Sep 16, 2024
Dirbaio
reviewed
Sep 16, 2024
Dirbaio
reviewed
Sep 16, 2024
Dirbaio
reviewed
Sep 16, 2024
ionspin
force-pushed
the
add-rp2350-trng-support
branch
2 times, most recently
from
September 17, 2024 19:22
08a9597
to
707a946
Compare
ionspin
force-pushed
the
add-rp2350-trng-support
branch
from
September 17, 2024 19:27
707a946
to
2bc4976
Compare
Dirbaio
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a driver for RP2350 TRNG, I used RNG driver from
embassy-nrf
as a template, but adapted to be more in line with other drivers inembassy-rp
.From 2350 datasheet:
They go on to note that Pico SDK and Pico Bootrom disable all entropy checks and sample as fast as possible from the TRNG ROSC directly, and then pass the data through SHA256 before using it (hardware accelerated in case of Bootrom) or xiroshiro128** (in case of pico-random library in Pico SDK , note that xiroshiro128** is verions 1.0 there) .
I've decided to leave the entropy checks enabled and datasheet recommended config for the TRNG default config as they seem to be sane.
Related to #3241