rp: Fix indexing for pins >31 on rp235xb #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
reviewed
Sep 11, 2024
embassy-rp/src/gpio.rs
Outdated
| @@ -953,7 +965,7 @@ macro_rules! impl_pin { | |||
| impl SealedPin for peripherals::$name { | |||
| #[inline] | |||
| fn pin_bank(&self) -> u8 { | |||
| ($bank as u8) * 32 + $pin_num | |||
| ($bank as u8) * 64 + $pin_num | |||
There was a problem hiding this comment.
if bank is bit 7, shouldn't this be 128?
There was a problem hiding this comment.
Ah, of course it is. I just didn't hit it because I'm not trying to use the qspi pins. The way pins are selected is a bit fiddly imo. When I get around to trying the gpio co-processor it should improve.
Dirbaio
approved these changes
Sep 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
spurious failure, forcing merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not handle using PIO with pins > 31, which is still broken.