Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Elyra to Kfp v2 #3219

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Migrate Elyra to Kfp v2 #3219

wants to merge 10 commits into from

Conversation

harshad16
Copy link
Contributor

What changes were proposed in this pull request?

Support for kfp v2.
This PR removed kfp-tekton from dependencies and allows only Argo to be used as controller runtime engine.

Related-to:
#1930
#2918

How was this pull request tested?

To test this PR:

  1. Run a make clean install at the root. This should install elyra-server and jupyter extensions.
  2. Configure the run time by setting up the endpoint to a v2 pipelines server.
  3. Run a pipeline against the runtime server.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@@ -729,7 +704,7 @@
pipeline.pipeline_properties.get(pipeline_constants.COS_OBJECT_PREFIX), pipeline_instance_id
)
# - load the generic component definition template
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v1"))
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v2"))

Check warning

Code scanning / CodeQL

Jinja2 templating with autoescape=False Medium

Using jinja2 templates with autoescape=False can potentially allow XSS attacks.
@iam4j4y
Copy link

iam4j4y commented May 20, 2024

Any update here?

@harshad16
Copy link
Contributor Author

Any update here?

Working on it , will require some more time to finish this.

@harshad16 harshad16 marked this pull request as ready for review August 12, 2024 15:44
@haiminh2001
Copy link

Hi, can I ask when will this PR be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants