-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pipeline version to 6 and pin versions #2321
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Leaving in draft until pipeline-editor is released and I update the version. I've updated it to point at the code sandbox for easier testing |
Tested migration using pipelines from the examples repository as follows:
Without example components installed
Without example components enabled
With example components installed and enabled
|
Migrate and run https://github.com/CODAIT/flight-delay-notebooks
|
Migrate and run https://github.com/CODAIT/covid-notebooks |
I just pushed an update to the code sandbox version with the latest fix from the pipeline editor PR. This includes bug fixes for all reported issues. I'll be working on addressing the tests next |
I wouldnt be opposed to removing these two examples from the repo given the amount of setup these require. Successfully migrated my AA and kfp 3.1.x and 3.2.x pipelines with these latest changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About to take a look at the code now but I just tried this out with a couple of older pipelines and it seemed to be working well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #2262
Sister PR to elyra-ai/pipeline-editor#172
Update the pipeline version and migration code to handle the changes
in Elyra 3.3
Pin package versions to prevent future backwards compatibility errors
Developer's Certificate of Origin 1.1