Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline version to 6 and pin versions #2321

Merged
merged 7 commits into from
Nov 30, 2021

Conversation

ajbozarth
Copy link
Member

@ajbozarth ajbozarth commented Nov 23, 2021

Fixes #2262

Sister PR to elyra-ai/pipeline-editor#172

Update the pipeline version and migration code to handle the changes
in Elyra 3.3

Pin package versions to prevent future backwards compatibility errors

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Nov 23, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ajbozarth
Copy link
Member Author

Leaving in draft until pipeline-editor is released and I update the version. I've updated it to point at the code sandbox for easier testing

@ptitzler
Copy link
Member

ptitzler commented Nov 23, 2021

Tested migration using pipelines from the examples repository as follows:

  • git clone examples repository
  • open legacy pipeline file (and perform migration)
  • save pipeline
  • verify properties view for each node
  • review .pipeline file content
  • run pipeline (* below indicates that the pipeline was not run, due to incomplete setup)
  • close pipeline
  • re-open pipeline

Without example components installed

  • For pipelines containing custom components migration "fails" as expected -> might want to tweak title wording and use "aborted", if possible
  • For pipelines containing only generic components migration succeeds (and yield the expected run results)

Without example components enabled

  • Migration "fails" as expected -> might want to tweak title wording and use "aborted", if possible

With example components installed and enabled

  • examples/pipelines/kubeflow_pipelines_component_examples (all pipelines)
  • examples/pipelines/airflow_component_examples/bash_operator
  • examples/pipelines/airflow_component_examples/email_operator
  • examples/pipelines/airflow_component_examples/http_operator
  • examples/pipelines/airflow_component_examples/slack_api_post_operator*
  • examples/pipelines/airflow_component_examples/spark_sql_operator*
  • examples/pipelines/airflow_component_examples/spark_submit_operator*

@ptitzler
Copy link
Member

ptitzler commented Nov 23, 2021

Migrate and run https://github.com/CODAIT/flight-delay-notebooks

  • on KFP
  • on AA

@ptitzler
Copy link
Member

ptitzler commented Nov 23, 2021

@ajbozarth ajbozarth added this to the 3.3.0 milestone Nov 24, 2021
@ajbozarth
Copy link
Member Author

I just pushed an update to the code sandbox version with the latest fix from the pipeline editor PR. This includes bug fixes for all reported issues. I'll be working on addressing the tests next

@akchinSTC
Copy link
Member

  • examples/pipelines/airflow_component_examples/spark_sql_operator*
  • examples/pipelines/airflow_component_examples/spark_submit_operator*

I wouldnt be opposed to removing these two examples from the repo given the amount of setup these require.
Currently fixing the slack integration connection on the test cluster to test.

Successfully migrated my AA and kfp 3.1.x and 3.2.x pipelines with these latest changes

@ajbozarth ajbozarth marked this pull request as ready for review November 30, 2021 18:55
Copy link
Member

@marthacryan marthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About to take a look at the code now but I just tried this out with a couple of older pipelines and it seemed to be working well.

@ajbozarth ajbozarth changed the title Update pipeline version to 6 Update pipeline version to 6 and pin versions Nov 30, 2021
@ajbozarth ajbozarth self-assigned this Nov 30, 2021
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ajbozarth ajbozarth merged commit cd0aea5 into elyra-ai:master Nov 30, 2021
@ajbozarth ajbozarth deleted the migrate_pipeline branch November 30, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle pipeline migration concerns for BYO catalog type changes
5 participants