Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't import private function name from router #91

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Don't import private function name from router #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23256a6
Underscore private function name in router
crbelaus Sep 10, 2024
ca133da
Update lib/error_tracker/web/router.ex
crbelaus Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/error_tracker/web/router.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ defmodule ErrorTracker.Web.Router do
# paths for navigating through the dashboard.
scoped_path = Phoenix.Router.scoped_path(__MODULE__, path)
# Generate the session name and session hooks.
{session_name, session_opts} = parse_options(opts, scoped_path)
{session_name, session_opts} = ErrorTracker.Web.Router.__parse_options__(opts, scoped_path)

scope path, alias: false, as: false do
import Phoenix.LiveView.Router, only: [live: 4, live_session: 3]
Expand All @@ -49,7 +49,7 @@ defmodule ErrorTracker.Web.Router do
end

@doc false
def parse_options(opts, path) do
def __parse_options__(opts, path) do
custom_on_mount = Keyword.get(opts, :on_mount, [])
session_name = Keyword.get(opts, :as, :error_tracker_dashboard)

Expand Down