-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Oban.PerformError grouping (#92)
This change improves how we store data from `Oban.PerformError` errors. Those errors don't come from exceptions, as they are delivered via Telemetry when the worker ends up with an `:error` or an `{:error, any()}` tuple. As they are not exceptions, there is no stack trace, and they were been detected as the same error by our fingerprinting algo. This changes introduces an fix that adds the worker module as the only stacktrace of the occurrence, so the error can populate the `source_function` attribute and different workers generate different error groupings. We cannot generate different error groups per different outputs of a worker. In that case, you should use `raise`, that generates a full stack trace and works as expected. Closes #87
- Loading branch information
Showing
4 changed files
with
24 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters