-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump TRS API specs #109
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #109 +/- ##
==========================================
+ Coverage 94.70% 94.88% +0.17%
==========================================
Files 12 12
Lines 586 586
==========================================
+ Hits 555 556 +1
+ Misses 31 30 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But I'm wondering: Don't the updated specs require any changes to the controllers at all?
Also, what exactly do you mean by:
Current specs do not support security definitions
?
Oh just that with the current updated specs for |
That's fine, we can add them through FOCA, no? If it's not in the specs, it just means we can do what we want 🤷 |
What about changes to controllers? None of the spec changes require behavioral changes? |
Yes we can add them via FOCA, we have just comment those specs for now. |
Nope, we had the edges covered. Minor change was required in one of the integration test. |
Approved! |
Description
Fixes #108
Type of change
Please delete options that are not relevant.
Checklist: