Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump TRS API specs #109

Merged
merged 9 commits into from
Aug 15, 2023
Merged

build: bump TRS API specs #109

merged 9 commits into from
Aug 15, 2023

Conversation

kushagra189
Copy link
Collaborator

Description

  • Update latest spec versions as defined here.
  • Minor tweaks in test cases.
  • Current specs do not support security definitions.

Fixes #108

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Maintenance

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
  • I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

@kushagra189 kushagra189 reopened this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17% 🎉

Comparison is base (d9f098f) 94.70% compared to head (7ba671e) 94.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #109      +/-   ##
==========================================
+ Coverage   94.70%   94.88%   +0.17%     
==========================================
  Files          12       12              
  Lines         586      586              
==========================================
+ Hits          555      556       +1     
+ Misses         31       30       -1     
Files Changed Coverage Δ
trs_filer/version.py 100.00% <100.00%> (+100.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushagra189 kushagra189 requested a review from uniqueg July 31, 2023 19:11
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I'm wondering: Don't the updated specs require any changes to the controllers at all?

Also, what exactly do you mean by:

Current specs do not support security definitions

?

@kushagra189
Copy link
Collaborator Author

Oh just that with the current updated specs for trs-filer, we have not added the bearer token and other definitions.

@uniqueg
Copy link
Member

uniqueg commented Aug 15, 2023

That's fine, we can add them through FOCA, no? If it's not in the specs, it just means we can do what we want 🤷

@uniqueg uniqueg changed the title Update latest open API Specs for TRS-Filer build: bump TRS API specs Aug 15, 2023
@uniqueg
Copy link
Member

uniqueg commented Aug 15, 2023

What about changes to controllers? None of the spec changes require behavioral changes?

@kushagra189
Copy link
Collaborator Author

That's fine, we can add them through FOCA, no? If it's not in the specs, it just means we can do what we want 🤷

Yes we can add them via FOCA, we have just comment those specs for now.

@kushagra189
Copy link
Collaborator Author

What about changes to controllers? None of the spec changes require behavioral changes?

Nope, we had the edges covered. Minor change was required in one of the integration test.

@uniqueg
Copy link
Member

uniqueg commented Aug 15, 2023

Approved!

@kushagra189 kushagra189 merged commit 2c7aef7 into dev Aug 15, 2023
6 checks passed
@kushagra189 kushagra189 deleted the maintainence/update_schemas branch August 15, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update trs-specs
2 participants