Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include all test files in linting #23

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: include all test files in linting #23

merged 1 commit into from
Jul 30, 2024

Conversation

athith-g
Copy link
Collaborator

@athith-g athith-g commented Jul 29, 2024

Change CI to include decryption tests in linting

Summary by Sourcery

This pull request updates the CI workflow to ensure that all test files are included in the linting process using pylint and ruff.

  • CI:
    • Updated CI workflow to include all test files in linting with pylint and ruff.

Copy link

sourcery-ai bot commented Jul 29, 2024

Reviewer's Guide by Sourcery

This pull request updates the CI configuration to ensure that all test files are included in the linting process. Specifically, the pylint and ruff commands in the .github/workflows/checks.yaml file were modified to lint all files in the 'tests' directory, rather than just those in 'tests/tasks'.

File-Level Changes

Files Changes
.github/workflows/checks.yaml Modified CI configuration to include all test files in linting.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @athith-g - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Collaborator

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@athith-g athith-g merged commit fbd2d5c into main Jul 30, 2024
1 check passed
@athith-g athith-g deleted the fix_linting branch July 30, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants