Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add move_files test #20

Merged
merged 8 commits into from
Jul 26, 2024
Merged

test: add move_files test #20

merged 8 commits into from
Jul 26, 2024

Conversation

athith-g
Copy link
Collaborator

@athith-g athith-g commented Jul 17, 2024

Adds tests for move_files.

Summary by Sourcery

This pull request introduces a new set of tests for the move_files function, ensuring its correct behavior under various scenarios including empty lists, unique files, duplicate file names, and non-existent directories.

  • Tests:
    • Added a new test class TestMoveFiles to verify the functionality of the move_files function.
    • Included tests for moving files with an empty list, moving unique files, handling duplicate file names, and dealing with non-existent directories.

Copy link

sourcery-ai bot commented Jul 17, 2024

Reviewer's Guide by Sourcery

This pull request adds a comprehensive test suite for the move_files function in the decryption module. The changes include importing the move_files function, creating a new TestMoveFiles class, and adding multiple test cases to ensure the function handles various scenarios correctly, such as moving files, handling empty lists, duplicate file names, and non-existent directories.

File-Level Changes

Files Changes
tests/decryption/test_decrypt.py Introduced a new test suite for the move_files function, including various test cases to validate its behavior under different conditions.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @athith-g - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 4 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tests/decryption/test_decrypt.py Show resolved Hide resolved
tests/decryption/test_decrypt.py Show resolved Hide resolved
tests/decryption/test_decrypt.py Show resolved Hide resolved
tests/decryption/test_decrypt.py Show resolved Hide resolved
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, minus this one very minor comment.

tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
@athith-g athith-g merged commit ccd1491 into main Jul 26, 2024
1 check passed
@athith-g athith-g deleted the add_move_tests branch July 26, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants