Improve the route/ingress selection

[lvarin]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have not reduced the existing code coverage
• I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
• I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

Summary by Sourcery

This pull request enhances the route selection mechanism by using the presence of the 'route.openshift.io/v1' API version to determine the route configuration, and removes the 'clusterType' variable from the deployment values configuration.

• Enhancements:
  • Improved the route selection logic by checking for the presence of the 'route.openshift.io/v1' API version instead of relying on the 'clusterType' value.
• Deployment:
  • Removed the 'clusterType' variable from the deployment values configuration.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request improves the route/ingress selection by updating the condition for OpenShift route creation and removing the clusterType variable from the values file. The changes ensure that the route is created based on the availability of the OpenShift API version rather than a predefined cluster type.

File-Level Changes

Files	Changes
deployment/templates/cloud-registry-route.yaml deployment/values.yaml	Improved the route/ingress selection by updating the condition for OpenShift route creation and removing the clusterType variable from the values file.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @lvarin - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}