Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run without docker #47

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: run without docker #47

merged 2 commits into from
May 24, 2024

Conversation

JaeAeich
Copy link
Contributor

Description

Run without docker

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JaeAeich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

cloud_registry/app.py Show resolved Hide resolved
cloud_registry/app.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b742271) to head (56f265b).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          189       189           
=========================================
  Hits           189       189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaeAeich
Copy link
Contributor Author

Please ignore above reviews, just wanted to see if this solution is viable or not to move further ahead and then implement it in tesk as well.

PS: read the foca issue comment I leaft, I think it would be a good idea to use jinja templating here.

@JaeAeich
Copy link
Contributor Author

JaeAeich commented May 24, 2024

Please merge it if you think this is ok :)

will discuss how to implement it in tesk in issues there!

@uniqueg
Copy link
Member

uniqueg commented May 24, 2024

Please merge it if you think this is ok :)

will discuss how to implement it in tesk in issues there!

If I approve a review, feel free to go ahead and merge :)

@uniqueg
Copy link
Member

uniqueg commented May 24, 2024

Oh, it seems I did not approve. My bad.

@uniqueg uniqueg self-requested a review May 24, 2024 13:20
@uniqueg uniqueg merged commit 68b9394 into dev May 24, 2024
6 checks passed
@uniqueg uniqueg deleted the docker branch May 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants