-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: clean up project configuration #41
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 5 -1
Lines 190 189 -1
=========================================
- Hits 190 189 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require some context here for pyproject.toml
context. Is this specific to cloud-registry or can we export it using foca and use it across other repositories? Want the reasoning for this migration for my understanding.
@uniqueg can you please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. LGTM. Happy to merge it as is, but if you like, you can update the version and/or use the drop in package for Flake8 pyproject.toml
support (see comments). Up to you.
yes, I have tried out the package. It works fine with no changes required in the config format. will integrate both of the above mentioned changes in the PR |
@uniqueg can you please have a look at the PR again, there have been dependency changes due to connexion's new release as well. |
Description
Move config for the following tools to
pyproject.toml
Move project metadata defined in
setup.py
topyproject.toml
Fixes #39
Type of change
Please delete options that are not relevant.
Checklist: