-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipv6 support #1204
base: master
Are you sure you want to change the base?
ipv6 support #1204
Conversation
lsh-0
commented
Nov 21, 2023
•
edited
Loading
edited
- fix routing on new subnets before launching new instance
- launch an ipv6 instance, ssh into it and run highstate successfully
- review
these will select either an ipv4 or ipv6 address, prefering ipv4
src/buildercore/trop.py
Outdated
@@ -408,10 +432,12 @@ def ec2_security(context): | |||
security_group_ports = _convert_ports_to_dictionary(security_group_data) | |||
ingress = merge_ports(ec2_ports, security_group_ports) | |||
|
|||
ipv6 = context['aws'].get('subnet-ipv6', False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not going to work with mixed-ip subnets
@@ -20,7 +20,7 @@ def _dummy_instance_is_active(find_ec2_instances, load_context, active_stack_nam | |||
}, | |||
} | |||
instance = MagicMock() | |||
instance.public_ip_address = '54.54.54.54' | |||
instance.public_ip_address = '54.54.54.54' # todo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo
…v6'. the project flags affect more than just subnets. the flags are at the 'aws' level because they'll need to be overwritten on a per-instance basis, rather than a per-project basis.
projects/elife.yaml
Outdated
# project supports IPv4 or IPv6 or both. | ||
# when both are true and circumstances forbid it (ec2 subnets), prefer IPv6 | ||
use-ipv4: true # create DNS A records, IPv4 CIDRs, use IPv4 subnets | ||
use-ipv6: false # create DNS AAAA records, IPv6 CIDRs, use IPv6 subnets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps just 'ipv4' and 'ipv6' ?