Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate button controllers - Gtk4 prep #787

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Sep 8, 2024

Extracted from #780 as far as possible.

As the handlers do not share significant code it is clearer to have them separate.

We will not need to keep additional references to the controllers in Gtk4

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me 👍

@danirabbit danirabbit merged commit a36ee04 into master Sep 8, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/rework-contextmenu branch September 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants