Continous saving of current tabs and tab-zooms

[ldrahnik]

Fixes #741

[jeremypw]

This is mostly working - thanks! A couple of issues:

• Changing the default font with <Control>scroll does not change settings because at the moment the Terminal Widget changes the font directly. You need to change the scroll handler to activate the relevant window action instead.

• I suggest you split the save_opened_terminals function up so that you can change the zooms and uris settings independently to save unnecessary work being done.

[ldrahnik]

Changing the default font with scroll does not change settings because at the moment the Terminal Widget changes the font directly. You need to change the scroll handler to activate the relevant window action instead.

8b126dd

I suggest you split the save_opened_terminals function up so that you can change the zooms and uris settings independently to save unnecessary work being done.

24ce4cc

[jeremypw]

You seem to have repeated a lot of code in save_open_terminals_with_zooms? Can you just call the split functions?

Adding another signal to the terminal widget is not the best solution - you can just activate the appropriate action in the scroll handler instead of calling increment_size and decrement_size. This can be done with code like
window.get_simple_action (MainWindow.ACTION_ZOOM_FONT_IN).activate (null); (other examples of this pattern are already used in the code)

I have made a couple of other comments inline.

[ldrahnik]

Adding another signal to the terminal widget is not the best solution - you can just activate the appropriate action in the scroll handler instead of calling increment_size and decrement_size. This can be done with code like
window.get_simple_action (MainWindow.ACTION_ZOOM_FONT_IN).activate (null); (other examples of this pattern are already used in the code)

0a0d06c

[ldrahnik]

You seem to have repeated a lot of code in save_open_terminals_with_zooms? Can you just call the split functions?

2574910

Maybe would be a better solution to make again one function but with bool value save_zooms to avoid duplicated cycles though opened terminals.

I think I processed all notes. Thank you for reviewing.

[ldrahnik]

db5843a

Handle the situation when is opened first terminal, then second one, second one is closed and then is laptop rebooted. Without this code would be saved tabs and tab-zooms from second terminal but should be from first one.

[jeremypw]

@ldrahnik I am fine with you merging the saving functions back into one with an extra parameter.

[ldrahnik]

@jeremypw Refactored to one function but with 2 bool parameters because I realized I do not know how to do that with only 1 - 1. state save only tabs, 2. state save only zooms, 3. state save both

[jeremypw]

It could be done with an enum as a parameter but probably not worth it in this case.

[jeremypw]

@ldrahnik One small thing I noticed - save_opened_terminals () get called before current_terminal is set leading to the critical warning gdouble vte_terminal_get_font_scale)VteTerminal*): assertion VTE_IS_TERMINAL(terminal) failed (MainWindow lin 1361)

Other than that it seems to work well now!

[ldrahnik]

One small thing I noticed - save_opened_terminals () get called before current_terminal is set leading to the critical warning gdouble vte_terminal_get_font_scale)VteTerminal*): assertion VTE_IS_TERMINAL(terminal) failed (MainWindow lin 1361)

2e059a2

[jeremypw]

I think this is good to go now - thanks for your contribution!

[jeremypw]

Need to fix CI workflow (or override) before can be merged.

[jeremypw]

Sorry, missed the fact that one of the unit tests now fails (CI was failing anyway in other PRs for an unrelated reason). The error given is

▶ 2/3 ERROR:../src/tests/Application.vala:155:__lambda53_: assertion failed (n_tabs == 1): (2 == 1) ERROR 

Not immediately obvious why this PR should affect the number of tabs - I'll investigate.

[jeremypw]

@ldrahnik I have pushed a PR to merge into this one that should fix the unit testing issue for now. The unit tests should probably be rewritten/extended to take continuous saving (or not) into account but that is complicated so can be left for another PR.

[ldrahnik]

@jeremypw Merged.