Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #83, #16 #147

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fixed #83, #16 #147

wants to merge 5 commits into from

Conversation

awissu
Copy link

@awissu awissu commented Nov 4, 2021

Fixes #16

All of the fixes in patch have been tested on openSUSE.
The build and testing is here.

@davidmhewitt
Copy link
Member

Hey, thank you for this!

I've taken part of this and opened #148 to fix #83 . You've been marked as a co-author there.

I'll review the other parts soon. We might want to take a different approach with the localectl stuff, as I think it should be possible to do this with DBus. I think the existing code that runs localectl on the command line is probably legacy that can be replaced with something better, so I don't want to add more just yet.

@danirabbit
Copy link
Member

@awissu if this branch is still relevant, would you mind resolving conflicts here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants