Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanguageView: Respect "main country" for locale selection #835

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

ryonakano
Copy link
Contributor

Taken from elementary/initial-setup#66.

Before

Language variants are not sorted alphabetically:
スクリーンショット 2024-10-12 06 42 58

The first variant in the list is always selected:
スクリーンショット 2024-10-12 06 39 22

After

Language variants are now sorted alphabetically:
スクリーンショット 2024-10-12 06 43 10

The "main country" is now always selected:
スクリーンショット 2024-10-12 06 39 59

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as described!

@danirabbit danirabbit merged commit 3576a9c into main Oct 15, 2024
5 checks passed
@danirabbit danirabbit deleted the ryonakano/locale-main-country branch October 15, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants