MainWindow: use Adw.NavigationView #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryonakano Can you see if this fixes #793 for you? I'm thinking it might be a bug with Leaflet on X11 |
Tried Testing Mode on X11, but unfortunately not:
test-screen0.webmThe following critical messages are shown on Terminal when clicking the storage bar: |
ryonakano
reviewed
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated Leaflet with NavigationView.
Since NavigationView doesn't have a property for disabling navigation, we replace the navigation stack to prevent navigation. There's some tricks with waiting for
shownso that we still get animations