Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowManager: don't start greeter in installer session #754

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 11, 2024

Fixes #732

Also fixes wingpanel taking a long time to show up

@danirabbit danirabbit marked this pull request as ready for review September 11, 2024 19:06
@danirabbit danirabbit requested a review from a team September 11, 2024 19:06
@ryonakano ryonakano self-requested a review September 11, 2024 22:04
@ryonakano
Copy link
Contributor

I tested this branch in the live ISO (by creating a hook). I confirmed #732 is fixed but elementary/installer#775 is not:

VirtualBox_test_12_09_2024_22_29_07

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update POTFILES for the renamed files?

@danirabbit
Copy link
Member Author

@ryonakano oh hm. I tested by booting a live ISO and installing there. Removed that linked issue and updated POTFILES!

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@ryonakano ryonakano merged commit bd4132a into master Sep 13, 2024
4 checks passed
@ryonakano ryonakano deleted the danirabbit/windowmanager-skipgreeterinstaller branch September 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Login card is displayed in the installer session
2 participants