Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitasking view: Display modal dialogs on top of parent window. #1900

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Apr 29, 2024

Removes a hack to automatically close multitasking view when window refuses to close. This branch displays new modal dialogs on top of a parent window.

Fixes #1898

Before:

Screenshot from 2024-04-29 23 34 19

After:

Screenshot from 2024-04-29 23 34 46

To do:

  • Fix dnd opacity transition
  • Fix duplicate windows in GTK4 demo
  • Test with multiple monitors
  • Simplify modal checks
  • Fix Files "Select Application" position

@lenemter lenemter requested a review from a team April 29, 2024 14:22
@lenemter lenemter removed the request for review from a team April 29, 2024 14:36
@lenemter lenemter marked this pull request as draft April 29, 2024 14:36
@leolost2605
Copy link
Member

leolost2605 commented May 6, 2024

Shoud fix #1898

Thank you!

but I can't test because Wayland session doesn't start for me :(

I unfortunately dont have much time currently but for me this is a problem with latest session settings and I probably should open an issue for it but a quick work around is install a HEAD~3 checkout or so :)

@lenemter
Copy link
Member Author

lenemter commented May 7, 2024

@leolost2605 Thank you! I managed to get it working after revering latest commit. And I can confirm that the branch fixes the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wayland: opening windows when overview is opened breaks a lot
3 participants