Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileOperations: Continue to move some report functions to Vala #2503

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

tintou
Copy link
Member

@tintou tintou commented Oct 8, 2024

Let's move chunk by chunk

@vjr
Copy link
Member

vjr commented Oct 8, 2024

Just leaving a link here (for future reference) if this issue fix can be accommodated in this PR or perhaps a follow-up one? -> #1748 (comment)

@tintou
Copy link
Member Author

tintou commented Oct 8, 2024

Just leaving a link here (for future reference) if this issue fix can be accommodated in this PR or perhaps a follow-up one? -> #1748 (comment)

That's for another one :)

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and no regressions found. Thanks!

@jeremypw jeremypw merged commit a1dd90f into main Oct 10, 2024
4 checks passed
@jeremypw jeremypw deleted the tintou/less-c branch October 10, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants