Make default calendar checkbox insensitive if read-only #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
approved these changes
Dec 10, 2021
|
My assumption is that it polls that information from contact details, although that's speculative as I don't use it. |
|
@mcclurgm Yes, I think your right. I am not sure how to add any birthdays and anniversaries using other Elementary apps. Friends is not released yet and doesnt seem to handle birthdays and anniversaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in #553. Previously we didn't check whether a calendar is read-only, so you could set it as default, with some strange results. This fixes that by disabling the checkbox.
Since a disabled checkbox can now mean multiple things (read-only calendar if unchecked, or already default if checked), should we add a label explaining why it's disabled? I'm not sure if that's necessary, but it could be helpful.