Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on musl libc #280

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix build on musl libc #280

wants to merge 1 commit into from

Conversation

CameronNemo
Copy link
Contributor

No description provided.

tintou
tintou requested changes Oct 18, 2018
View reviewed changes
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that you're checking if _NL_TIME_WEEK_1STDAY is declared in the meson file but I can't see any change in meson.build, did you forget to push something?

@CameronNemo
Copy link
Contributor Author

CameronNemo commented Oct 18, 2018 •
edited
Loading

Looks like your meson is too old for this one. You can close the ticket or leave it open for when you target meson >= 0.47.

@CameronNemo
Copy link
Contributor Author

CameronNemo commented Mar 4, 2019 •
edited
Loading

Any update on this? The meson version is fine, I was mistaken.

@jeremypw
Copy link
Collaborator

@tintou Is this OK now?

@spotlesscoder
Copy link

This PR is quite old. Any updates on this?

@CameronNemo
Copy link
Contributor Author

I addressed the issues tintou pointed out.

@CameronNemo
Copy link
Contributor Author

Rebased this commit. Let me know if there need to be any changes.

@jeremypw
Copy link
Collaborator

@CameronNemo In order to shorten the review list, I am converting this to draft as there are conflicts and no recent activity. Please fix the conflicts and then re-request a review from @tintou and/or @elementary/desktop-developers, thanks.

@jeremypw jeremypw marked this pull request as draft May 11, 2021 17:51
@paper42 paper42 mentioned this pull request Mar 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CameronNemo @jeremypw @spotlesscoder @tintou