-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The behaviour when creating new events should be logical and consistent with regard to the "mark as default calendar" option #553
Comments
I have a feeling this is caused by #550, but I'm not sure. Since the check/uncheck behavior doesn't seem to work at all, I wouldn't be surprised if there actually is still a default calendar but the check box doesn't reflect that. This is all speculation though. |
Do you have an idea how we can find out and solve this? |
No sorry... I've never dealt with that part of the codebase. I imagine that the signal we send when you click the check button may be wrong. If you have experience looking at our code, that's where I'd start, but I'm going to (work allowing) do that soon too. |
We just fixed #550, so the checkbox behavior should be at least a little nicer. I don't really understand what the issue is here, so can you try rebuilding from git and let me know if you're still seeing it? |
Unfortunately I don't have time to rebuild it from git right now. Maybe someone else? |
Fair enough. We just released an update with the changes, so if you have the time to give that a try that would be great! Otherwise no worries. |
@4jNsY6fCVqZv Now that Odin is released, could you have a look and see if the issue still exists? I don't really understand what the issue is you're describing here, but the current release has the fix to the default calendar picker. |
@mcclurgm Haven't switched to Odin yet, I'll try as soon as possible. |
The issue I wanted to show is that once no default calendar is set, it is possible to create new events, but they are not shown in the calendar. I would expect that if it is a requirement that a default calendar has to be set, then without it there should be no way to create a new event. And then, if necessary, a notification appears that a default calendar must be set first. I have tested it with Odin. With version 6.0.3 the last calendar is automatically the default calendar. The check mark cannot be removed and is grayed out. So I can close this issue with gratitude! |
I have experimented a bit more. |
Thanks for looking into this. That appears to be two separate issues: one is that you can remove the last calendar, and one is that you can set read-only calendars as default. I'm going to open new issues for each of those and close this, since it appears that the original issue around the default checkbox is fixed. If I'm misunderstanding, feel free to reopen. One question: I'm not sure what you mean by the last sentence
Could you please clarify? What do you mean by "calendar overview" and what doesn't appear, the event or the "Birthdays & Anniversaries" calendar? |
Thanks for taking a closer look at the Issues!
I don't know what the exact name for it is right now. I just mean the normal month view. And it is the event that does not appear for me. |
That clears it up, thank you! I assume this is because the calendar is read only, but I’m not sure how to detect that. I’ll do a bit more digging and open a new issue when I’ve figured out the cause. |
Then this calendar probably shouldn't automatically become the default calendar, right? #726 Thank you for looking into the issue and creating more issues for it if necessary! |
One thing irritates me:
At first glance, it seems that it is mandatory to define a default calendar in order to create an event. However, test5 & test6 can be created after I have already unchecked the default calendar option again. That seems inconsistent to me.
Beyond my observation, I wonder whether it should be necessary for the creation of new events to have at least one standard calendar defined before. And I also wonder if it should even be possible to start creating an event using the "Create an event" button without setting a default calendar. Or whether the button should remain insensitive until I have done so.
My expectation as a user would in any case be consistent behaviour.
I use the latest stable and unmodified Hera version including all updates.
Somehow also connected with this issue #544
Again, the "Create Event" dialog can be started, although it looks like the conditions for creating a new event are not yet fulfilled.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: