Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto copy adjustment #3649

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Crypto copy adjustment #3649

merged 6 commits into from
Oct 10, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 10, 2024

Content

Small iteration on the UI of 3 screen related to crypto. See the recorded screens to see the diff.

Motivation and context

Screenshots / GIFs

image image

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Oct 10, 2024
@bmarty bmarty requested a review from a team as a code owner October 10, 2024 15:33
@bmarty bmarty requested review from jmartinesp and removed request for a team October 10, 2024 15:33
@bmarty bmarty added Z-NextRelease For issues and PRs which should be included in the NextRelease. Run-Maestro Starts a Maestro Cloud session to run integration tests labels Oct 10, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 10, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I haven't thoroughly tested it.

Copy link
Contributor

github-actions bot commented Oct 10, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/h2vLoM

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.80%. Comparing base (c6d3ad8) to head (266210e).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...atures/verifysession/impl/VerifySelfSessionView.kt 95.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3649   +/-   ##
========================================
  Coverage    82.79%   82.80%           
========================================
  Files         1747     1747           
  Lines        41756    41774   +18     
  Branches      5103     5107    +4     
========================================
+ Hits         34572    34589   +17     
- Misses        5369     5370    +1     
  Partials      1815     1815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 10, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 10, 2024
@bmarty bmarty enabled auto-merge October 10, 2024 17:13
@bmarty bmarty merged commit 673de64 into develop Oct 10, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/cryptoCopyAdjustment branch October 10, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants