Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag IdentityPinningViolationNotifications. #3648

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 10, 2024

Content

Disabled in production build, enabled by default on other builds.

Motivation and context

See linked issue (internal).

Screenshots / GIFs

Tests

  • Ensure that when the flag is disabled, there is no pin violation notification displayed in the room.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

Disabled in production build, enabled by default on other builds.
@bmarty bmarty requested a review from a team as a code owner October 10, 2024 14:29
@bmarty bmarty requested review from ganfra and removed request for a team October 10, 2024 14:29
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 10, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/6kMoo2

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (366db47) to head (aa07ab1).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/libraries/featureflag/api/FeatureFlags.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3648   +/-   ##
========================================
  Coverage    82.82%   82.82%           
========================================
  Files         1747     1747           
  Lines        41742    41754   +12     
  Branches      5102     5103    +1     
========================================
+ Hits         34572    34583   +11     
  Misses        5355     5355           
- Partials      1815     1816    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 9c7f2b9 into develop Oct 10, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/identityChangeFeatureFlag branch October 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants